You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
1 - Open a file with some content on the editor
2 - Open "Find" widget (CTRL + F)
3 - Search for content on open file
4 - Select some text on the editor that does not match the find criteria
5 - Click on the input box of the "Find" widget
6 - Try to add selection to next find match (CTRL + D)
7 - New selections that match the find criteria are added to Multicursor, but the text selected on step 4 also belongs to the current selection group.
I would expect that, in the presented scenario, the text selected on step 4 to be dismissed since it does not match the criteria. Please note that, if after step 5 you change the value of the input box (change criteria), this issue does not occur, since the selection will move to the next found occurrence.
I have checked this while I was implementing the unit test for the #211550 PR. Besides trying this on latest OSS dev version, I have checked on V1.88.1 (Linux) and V1.87.2 (Windows) and this issue also occurs.
Please let me know if you agree that this is a problem and, in that case, if my expectation is aligned with yours and I can then volunteer myself to implement the fix.
VS Code version: Code - OSS Dev 1.90.0 (Commit unknown, Date unknown)
OS version: Linux x64 6.5.0-1018-azure
Modes:
Type: Bug
1 - Open a file with some content on the editor
2 - Open "Find" widget (CTRL + F)
3 - Search for content on open file
4 - Select some text on the editor that does not match the find criteria
5 - Click on the input box of the "Find" widget
6 - Try to add selection to next find match (CTRL + D)
7 - New selections that match the find criteria are added to Multicursor, but the text selected on step 4 also belongs to the current selection group.
I would expect that, in the presented scenario, the text selected on step 4 to be dismissed since it does not match the criteria. Please note that, if after step 5 you change the value of the input box (change criteria), this issue does not occur, since the selection will move to the next found occurrence.
I have checked this while I was implementing the unit test for the #211550 PR. Besides trying this on latest OSS dev version, I have checked on V1.88.1 (Linux) and V1.87.2 (Windows) and this issue also occurs.
Please let me know if you agree that this is a problem and, in that case, if my expectation is aligned with yours and I can then volunteer myself to implement the fix.
VS Code version: Code - OSS Dev 1.90.0 (Commit unknown, Date unknown)
OS version: Linux x64 6.5.0-1018-azure
Modes:
System Info
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: disabled_software
multiple_raster_threads: enabled_on
opengl: disabled_off
rasterization: disabled_software
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: disabled_software
video_encode: disabled_software
vulkan: disabled_off
webgl: unavailable_software
webgl2: unavailable_software
webgpu: disabled_off
The text was updated successfully, but these errors were encountered: