Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selection to next find match (CTRD + D) does not check current selection when changing focus back from editor to find widget #211577

Open
BrunoSoaresEngineering opened this issue Apr 28, 2024 · 0 comments
Assignees

Comments

@BrunoSoaresEngineering
Copy link
Contributor

Type: Bug

1 - Open a file with some content on the editor
2 - Open "Find" widget (CTRL + F)
3 - Search for content on open file
4 - Select some text on the editor that does not match the find criteria
5 - Click on the input box of the "Find" widget
6 - Try to add selection to next find match (CTRL + D)
7 - New selections that match the find criteria are added to Multicursor, but the text selected on step 4 also belongs to the current selection group.

Recording

I would expect that, in the presented scenario, the text selected on step 4 to be dismissed since it does not match the criteria. Please note that, if after step 5 you change the value of the input box (change criteria), this issue does not occur, since the selection will move to the next found occurrence.

I have checked this while I was implementing the unit test for the #211550 PR. Besides trying this on latest OSS dev version, I have checked on V1.88.1 (Linux) and V1.87.2 (Windows) and this issue also occurs.

Please let me know if you agree that this is a problem and, in that case, if my expectation is aligned with yours and I can then volunteer myself to implement the fix.

VS Code version: Code - OSS Dev 1.90.0 (Commit unknown, Date unknown)
OS version: Linux x64 6.5.0-1018-azure
Modes:

System Info
Item Value
CPUs AMD Ryzen 9 5900X 12-Core Processor (12 x 4450)
GPU Status 2d_canvas: unavailable_software
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: disabled_software
multiple_raster_threads: enabled_on
opengl: disabled_off
rasterization: disabled_software
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: disabled_software
video_encode: disabled_software
vulkan: disabled_off
webgl: unavailable_software
webgl2: unavailable_software
webgpu: disabled_off
Load (avg) 0, 0, 0
Memory (System) 23.00GB (6.85GB free)
Process Argv . --disable-background-networking --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-default-apps --disable-dev-shm-usage --disable-renderer-backgrounding --disable-sync --metrics-recording-only --no-first-run --no-default-browser-check --user-data-dir=/home/bruno/.vscode-oss-dev --inspect-brk=5875 --no-cached-data --crash-reporter-directory=/home/bruno/90_ownProjects/00_Repos/vscode/.profile-oss/crashes --disable-features=CalculateNativeWinOcclusion --disable-extension=vscode.vscode-api-tests --remote-debugging-port=9222
Screen Reader no
VM 0%
DESKTOP_SESSION undefined
XDG_CURRENT_DESKTOP Unity
XDG_SESSION_DESKTOP undefined
XDG_SESSION_TYPE x11
Extensions disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants