Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion Failure When Extension Throws Error #211636

Open
hediet opened this issue Apr 29, 2024 · 0 comments
Open

Assertion Failure When Extension Throws Error #211636

hediet opened this issue Apr 29, 2024 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors)

Comments

@hediet
Copy link
Member

hediet commented Apr 29, 2024

Implementation:

public async resolveCustomTextEditor(
		document: TextDocument,
		webviewPanel: WebviewPanel,
		token: CancellationToken
	): Promise<void> {
		throw new Error("invalid document extension!");
}

Error message when I open such a custom text editor:

Code_-_Insiders_g0TzYbmo5j

Code_-_Insiders_1FScZwOBtv

I think the extension error message should be shown instead and not the internal assertion failure message.

@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors) labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors)
Projects
None yet
Development

No branches or pull requests

2 participants