Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic SCM icon is not consistent with other icons #21192

Closed
Tyriar opened this issue Feb 22, 2017 · 2 comments
Closed

Generic SCM icon is not consistent with other icons #21192

Tyriar opened this issue Feb 22, 2017 · 2 comments
Assignees
@joaomoreno
Labels
polish Cleanup and polish issue scm General SCM compound issues
Milestone
March 2017

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 22, 2017

#20999

  • Stroke is not as strong
  • Border isn't as crisp
  • Different size: 20x24 (scm) vs 19x23 (explorer)

image

image
@Tyriar Tyriar added polish Cleanup and polish issue scm General SCM compound issues labels Feb 22, 2017
@joaomoreno joaomoreno added this to the March 2017 milestone Feb 22, 2017
@rkeithhill
Copy link

And it looks too much like the Explorer icon and it lacks any sort of "character". I'd prefer the icon default to Git when no workspace is opened and then switch to a particular SCM's icon when the type of SCM is detected.

@joaomoreno
Copy link
Member

Not applicable any more. Went through a bunch of icons yesterday with @egamma and settled on

image

@joaomoreno joaomoreno mentioned this issue Apr 10, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
polish Cleanup and polish issue scm General SCM compound issues
Projects
None yet
Milestone
March 2017
Development

No branches or pull requests
3 participants
@joaomoreno @Tyriar @rkeithhill