Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCM viewlet focus colors need work #21202

Closed
Tyriar opened this issue Feb 22, 2017 · 2 comments
Closed

SCM viewlet focus colors need work #21202

Tyriar opened this issue Feb 22, 2017 · 2 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues scm General SCM compound issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 22, 2017

#20999

You cannot tell the difference between an opened diff editor and a focused diff editor line in the viewlet:

Diff editor is opened and focused:

image

Diff editor line is focused:

image

Clean button focused (needs more contrast):

image

.travis.yml is focused, .gitignore is open (this looks like the opposite of what it should be to me):

image


For reference here's the explorer:

Item focused:

image

Editor focused:

image

.travis.yml is focused, .gitignore is open (again this looks like the opposite of what it should be to me, cc @bpasero):

image

@Tyriar Tyriar added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues scm General SCM compound issues labels Feb 22, 2017
@bpasero
Copy link
Member

bpasero commented Feb 22, 2017

This is probably due to using the list widget vs tree widget that has different styles. +1 for same looks.

@joaomoreno joaomoreno modified the milestones: February 2017, March 2017 Feb 22, 2017
@joaomoreno
Copy link
Member

joaomoreno commented Mar 30, 2017

The current list colors are now exactly the same as the tree's. As for the opposite, we'll let theming solve it. 👍

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues scm General SCM compound issues
Projects
None yet
Development

No branches or pull requests

3 participants