Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle Skipping This File does not work #22432

Closed
roblourens opened this issue Mar 11, 2017 · 4 comments
Closed

Toggle Skipping This File does not work #22432

roblourens opened this issue Mar 11, 2017 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)
Milestone

Comments

@roblourens
Copy link
Member

node2/chrome will change the presentationHint as a source is dynamically skipped/unskipped, but it seems like this is now cached during a debug session and can't be changed.

  • Start a node2/chrome debug session
  • Use "Toggle skip status" from context menu
  • See that the presentationHint is now changed on returned frames, but the UI doesn't reflect the change.
@isidorn
Copy link
Contributor

isidorn commented Mar 14, 2017

For now I did a not super nice fix to make it possible for the presentaionHint to be updated during a session. In the future if needed I will allow for the whoel source object to be rewritten by the adapter

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Mar 14, 2017
@isidorn isidorn added this to the March 2017 milestone Mar 14, 2017
@roblourens
Copy link
Member Author

Now when I run "Toggle skip status", nothing happens and it appears to not be running the command. My breakpoint isn't hit at least. Do you see that? It activates the extension but doesn't run the command.

@isidorn
Copy link
Contributor

isidorn commented Mar 27, 2017

Yes I see the same, from my point your command does not even call into my customDebugRequest

@roblourens can you please debug into if your command gets called at all.
If not please check with Joh if something changed in extension contributing commands to menus

@isidorn isidorn reopened this Mar 27, 2017
@isidorn isidorn changed the title PresentationHint can't change during a debug session Toggle Skipping This File does not work Mar 27, 2017
@roblourens
Copy link
Member Author

#23162

@isidorn isidorn added the *duplicate Issue identified as a duplicate of another issue(s) label Mar 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants