language specific editor.wordBasedSuggestions setting doesn't override the global setting

[StanislawStempin]

• VSCode Version: 1.10.2
• OS Version: Windows 10 1607 14393.693

Steps to Reproduce:

1. Create a new empty folder and open it in VSCode
2. In that folder - create a new xml file
3. Open workspace settings and set the following settings:
   '''{
   "editor.wordBasedSuggestions": true,
   "[xml]": {
   "editor.wordBasedSuggestions": false
   }
   }
   '''
4. Open the XML file, type a few words and press Ctrl+Space

Actual result:
Word based suggestions show up
Expected result:
No suggestions showing up

[sandy081]

@jrieken Looks like wordBasedSuggestions config is being read without lang id.

[jrieken]

Please advise how @sandy081. There is nothing obvious on the service: const { wordBasedSuggestions } = this._configurationService.getConfiguration<IEditorOptions>('editor');

[sandy081]

@jrieken Agreed, service api is not explicit. You can get language options as follows

this._configurationService.getConfiguration<IEditorOptions>({section: 'editor', overrideIdentifier: <langId>})

[sandy081]

@jrieken Not sure why are we not getting editor settings from the editor instead of asking the service again?

[jrieken]

Because this is done as service which isn't aware of an editor, just knowing models. That's how the API of a completion provider looks like.