Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text content provider: option to indicate that a model is disposed #22741

Closed
bpasero opened this issue Mar 16, 2017 · 6 comments
Closed

Text content provider: option to indicate that a model is disposed #22741

bpasero opened this issue Mar 16, 2017 · 6 comments
Assignees
Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Mar 16, 2017

Steps to Reproduce:

  1. debug an extension
  2. step into our extension host code
  3. stop debugging

=> you see an empty editor still even though after stopping the debug session I would either expect the contents to still be there or the editor to close

image

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Mar 16, 2017
@isidorn isidorn added this to the March 2017 milestone Mar 16, 2017
@isidorn
Copy link
Contributor

isidorn commented Mar 17, 2017

@bpasero Ok, fixed this issue however there is still something.

When I do a model.dispose, you keep the editor open with no contents.
I need some way to tell you drop this model and ask me again for contents - is there a mechanism for this currently?

@bpasero
Copy link
Member Author

bpasero commented Mar 17, 2017

@isidorn where do you dispose the model?

@isidorn
Copy link
Contributor

isidorn commented Mar 17, 2017

@bpasero currently I do not, but I was before this fix. But what I want to do is the following

  • Internal modules may change between sessions, thus I need to somehow notify the workbench that the model updated
  • On session start dispose all old models so you would ask me for new content

@bpasero
Copy link
Member Author

bpasero commented Mar 17, 2017

@isidorn I think what is missing in the text content provider business is to indicate when a model is no longer valid. I think we should not leave editors open after a session has ended but instead signal back that the model is no longer valid which in turn should cause the editor to close.

See #18651 for a similar issue in git land.

Let's reopen this one, I think the problem is still present.

@bpasero bpasero reopened this Mar 17, 2017
@isidorn
Copy link
Contributor

isidorn commented Mar 17, 2017

@bpasero yes exactly, I'll sync with @joaomoreno next week on this

@isidorn isidorn modified the milestones: April 2017, March 2017 Mar 23, 2017
@isidorn isidorn modified the milestones: May 2017, April 2017 Apr 25, 2017
@isidorn isidorn modified the milestones: Backlog, May 2017, On Deck May 12, 2017
@isidorn isidorn changed the title Read-only inlined content from source map not closed when debug session is over Text content provider: option to indicate that a model is disposed Nov 13, 2017
@isidorn isidorn added debt Code quality issues workbench and removed bug Issue identified by VS Code Team member as probable bug labels Nov 13, 2017
@isidorn isidorn modified the milestones: On Deck, Backlog Nov 13, 2017
@bpasero bpasero removed the workbench label Nov 16, 2017
@isidorn
Copy link
Contributor

isidorn commented Sep 20, 2018

Once we have it for the Git I will adopt it here. No need to keep this issue around

@isidorn isidorn closed this as completed Sep 20, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

No branches or pull requests

2 participants