-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text content provider: option to indicate that a model is disposed #22741
Comments
@bpasero Ok, fixed this issue however there is still something. When I do a model.dispose, you keep the editor open with no contents. |
@isidorn where do you dispose the model? |
@bpasero currently I do not, but I was before this fix. But what I want to do is the following
|
@isidorn I think what is missing in the text content provider business is to indicate when a model is no longer valid. I think we should not leave editors open after a session has ended but instead signal back that the model is no longer valid which in turn should cause the editor to close. See #18651 for a similar issue in git land. Let's reopen this one, I think the problem is still present. |
@bpasero yes exactly, I'll sync with @joaomoreno next week on this |
Once we have it for the Git I will adopt it here. No need to keep this issue around |
Steps to Reproduce:
=> you see an empty editor still even though after stopping the debug session I would either expect the contents to still be there or the editor to close
The text was updated successfully, but these errors were encountered: