Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed Task Api Feedback #23435

Closed
2 of 3 tasks
jrieken opened this issue Mar 28, 2017 · 1 comment
Closed
2 of 3 tasks

Proposed Task Api Feedback #23435

jrieken opened this issue Mar 28, 2017 · 1 comment
Assignees
Labels
api tasks Task system issues
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Mar 28, 2017

re #23280

  • The TaskSet has two optional arrays allowing to list id of task that are test-tasks or build-tasks. While it's not entirely clear to me what that means it is somewhat cumbersome to repeat the ids there again, esp if I have created them programmatically. Chances are high I will add some sort of properly on my tasks for that and therefore I'd propose we make the API like that. Something like [ShellTask|ProcessTask]#kind which is an enum spelling out different task kinds
  • Var-args like this constructor(name: string, commandLine: string, ...problemMatchers: ProblemMatcher[]); look nice but put in a corner wrt to evolving the API. You won't be able to add another parameter easily
  • There is Task#identifier but there is no obvious reason why. It seems to be an internal property or does it surface in the UI in some form?
@dbaeumer dbaeumer added api tasks Task system issues labels Apr 25, 2017
@dbaeumer dbaeumer added this to the May 2017 milestone Apr 25, 2017
@dbaeumer
Copy link
Member

I addressed the two first one. The identifier is basically optional but needed since I can't force UI names to be unique. If not provided then a task is using the name but when reference by another task there might be ambiguity. Then a user can add an identifier to make the fully unique. The tasks.json basically offers the same functionality.

@kieferrm kieferrm mentioned this issue May 19, 2017
44 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api tasks Task system issues
Projects
None yet
Development

No branches or pull requests

2 participants