Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed preLaunchTask's should abort debugger launch #2370

Closed
gregg-miskelly opened this issue Jan 26, 2016 · 1 comment
Closed

Failed preLaunchTask's should abort debugger launch #2370

gregg-miskelly opened this issue Jan 26, 2016 · 1 comment
Assignees
@isidorn
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verified Verification succeeded
Milestone
Feb 2016

Comments

@gregg-miskelly
Copy link
Member

Currently errors in preLaunchTask's are silently ignored. This is a big problem for any compiled language which uses preLaunchTask to compile the code as this means that any build errors are ignored.
@isidorn isidorn added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Jan 26, 2016
@isidorn isidorn self-assigned this Jan 26, 2016
@isidorn isidorn added this to the Feb 2016 milestone Feb 2, 2016
@egamma egamma mentioned this issue Feb 2, 2016
Closed
97 tasks
@isidorn isidorn closed this as completed in d68d838 Feb 8, 2016
@isidorn
Copy link
Contributor

isidorn commented Feb 8, 2016

After a preLaunchTask has finished we now check if there are errors in the workspace, however in our task framework we do not have a connection if a task produced an error. So it might happen that there is an unrelated error in the workspace (e.g some malformed json). Due to this in the message we offer the user to debug anyway.
This should also work for watching tasks.

screen shot 2016-02-08 at 15 40 49

@isidorn isidorn added the verified Verification succeeded label Feb 26, 2016
@isidorn isidorn mentioned this issue Mar 8, 2016
Closed
@joaomoreno joaomoreno mentioned this issue Mar 15, 2016
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Milestone
Feb 2016
Development

No branches or pull requests
2 participants
@isidorn @gregg-miskelly