Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the widgetactions debug UI reflect the state of a focused thread #23878

Merged
merged 1 commit into from
Apr 13, 2017

Conversation

QwertyZW
Copy link
Contributor

@QwertyZW QwertyZW commented Apr 4, 2017

Currently when we have a multi-threaded debugging session open, Continuing a thread and having another stopped thread get autofocused on the first thread's exit, or simply manually focusing a stopped thread, causes the widgetactions debugger UI to reflect the stale running state of the old thread instead of the stopped state of the newly focused thread, leaving no means to continue any of the stopped threads.

The commit here fixes that.

The editor and the debug viewlet appear to reflect the state of the debugger correctly.

If you require I can open an issue specific to this PR and attach a gif capture of my screen to better explain myself if that's required.

@mention-bot
Copy link

@QwertyZW, thanks for your PR! By analyzing the history of the files in this pull request, we identified @egamma and @joaomoreno to be potential reviewers.

@msftclas
Copy link

msftclas commented Apr 4, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@QwertyZW
Copy link
Contributor Author

QwertyZW commented Apr 4, 2017

/cc @isidorn

@QwertyZW QwertyZW changed the title Let the debug UI reflect the state of a focused thread Let the widgetactions debug UI reflect the state of a focused thread Apr 4, 2017
@isidorn isidorn added this to the April 2017 milestone Apr 4, 2017
@isidorn
Copy link
Contributor

isidorn commented Apr 13, 2017

Thanks you for the great explanation and this PR.
Your fix is good however there seems to be an underlying issue which I should look into in the future - since the seassion state map should reflect the same stopped state. Not sure why that is not the case and why your additional check is needed.

@isidorn isidorn merged commit b016327 into microsoft:master Apr 13, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants