New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File explorer opens file under cursor on [Esc] key. #24232
Comments
@LexRiver what do you do exactly, can you share a video? |
Is it just me?
If this is just me, then sorry. |
I can reproduce and fix. |
-- Sorry for the English, I used Google Translator --
@bpasero Now when you click Esc the focus is not going back to the file you were editing, but getting a blue border, time in "Open Editors" time in the whole project. Can you reproduce? The change that only affects where all the files are or also for "Open Editors"? |
@Tekbr there was no change for "Open Editors", only the "Files Explorer" below. |
@bpasero Was not the idea to return the focus of the cursor to editing the file? 🤔 |
No, that was not the idea. |
I was expecting to continue editing the opened file also -) |
-- Sorry for the English, I used Google Translator -- @bpasero In my view the idea was always this.
It may be a lack of interpretation or even wrong understanding. Notice that @LexRiver himself said again that the idea was to go back to the edited file.
For me it got worse than before. I vote for reopening the issue, and check if it's possible to do this by going back to the file. I do not know if @LexRiver agrees. |
How about assigning a keybinding that ESC puts focus to the editor when pressed while the explorer has focus? Otherwise I do not understand the request to reopen this bug that was fixed, sorry. |
-- Sorry for the English, I used Google Translator --
@bpasero Corrected in parts, because that was not what was asked for. Sorry for the sincerity. 😉 Before I used it in a different way, a "jerry-rig" (I think that's the English term, if not sorry), but that worked more or less. And that stopped after the update. I looked for the case and found this one. But that is beside the point.
I do not understand much, but I guess that's what I mean? The idea is to work as in Atom. 1- Type a text For VSCode my idea is (see if @LexRiver agrees): 1- Type a text @bpasero Tell me if I need to open a new issue for this situation. This step is now something I hate about VSCode (especially now after it's changed), and if it can be fixed (or if it's a config), it has a bit of a bearing on that case. (I do not know if you'll understand, sorry for English again) 1- Type a text This is very boring!! Maybe Ctrl + 0 (not numeric) will focus on Open Editors and Ctrl + Shift + E in the file tree. |
@Tekbr just configure this in your keybindings file:
I can see how previously we would focus back the editor on escape, but this behaviour was actually just a bug (as reported by LexRiver). It was never the intention to do so and we are not doing so in other views. |
-- Sorry for the English, I used Google Translator -- @bpasero Sorry for the delay in responding !! Yes, your tip worked for Esc. (Should have come by default). It's possible? But I do not understand why the focus (blue bar in the files tree). Do these steps (using only the keybindings that you mentioned above): Another situation: I searched and found "Focus on Open Editors" Ctrl + k E. That is, it does not make sense to me when I hit Ctrl + Shift + E in the above situations it points to Open Editors. If you were confused or did not understand something, let me know. Or make a gif if you prefer. Sorry for using Google Translate. |
The blue focus in the tree is for accessibility reasons, you can start to arrow up or down in this mode to start selecting entries from the tree. |
-- Sorry for the English, I used Google Translator -- @bpasero Question 1: But did you do the steps I spoke up? Should this really happen?
Question 2: Yes, but I can not access the main folder with the up and down arrow. If I want to create a new folder or a new file, using the 'Menu' key, right? Or am I doing something wrong? |
Agree, in your case focus should go back to the explorer even though it has no focused item. |
-- Sorry for the English, I used Google Translator --
If what I have written is confusing, please let me know that I will try to write in another way. 😉 |
@Tekbr let's tackle individual issues in individual bug reports, makes it easier to track. Feel free to open new issues as you see fit. |
Steps to Reproduce:
Expected behavior:
Current behavior:
The text was updated successfully, but these errors were encountered: