Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MERN Starter Kit: Error reporting is inconsistent #24272

Closed
ramya-rao-a opened this issue Apr 7, 2017 · 2 comments
Closed

MERN Starter Kit: Error reporting is inconsistent #24272

ramya-rao-a opened this issue Apr 7, 2017 · 2 comments
Assignees
Labels
info-needed Issue requires more information from poster javascript JavaScript support issues typescript Typescript support issues

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Apr 7, 2017

Test tour MERN - #22277

  • VSCode Version: Insiders
  • OS Version: Mac

Steps to Reproduce:

  1. Open index.js, change any of the require to require123 : No error
  2. Open index.js, add boohoo() anywhere : No error
  3. Open server.js, change console.error to console.errr : No error
  4. Open server.js, add boohoo() anywhere : Error shown: eslint: boohoo is not defined
  5. Open server.js, change dummyData() to dummyDta(): Error shown: eslint: dummyDta is not defined
  6. Open post.controller.js, change Post.find() to Post.fin(): No error

Also, npm run build doesn't find any of these errors.

Meaning if there was a typo, user wouldn't know until the program is run.

@mjbvz mjbvz added javascript JavaScript support issues typescript Typescript support issues labels Apr 20, 2017
@mjbvz
Copy link
Contributor

mjbvz commented Apr 20, 2017

Since the errors are coming from ESLint here, would this issue be with that extension instead of with our core js/ts support? Perhaps it just needs to be configured correctly to report errors in all cases?

The checkJS flag in TS 2.3.1 may also be interesting to try out on these files

@mjbvz mjbvz added the info-needed Issue requires more information from poster label Apr 20, 2017
@mjbvz
Copy link
Contributor

mjbvz commented May 5, 2017

Verified that all of these are now reported as errors by adding // @ts-check to the file or setting "javascript.implicitProjectConfig.checkJs": true

@mjbvz mjbvz closed this as completed May 5, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster javascript JavaScript support issues typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

2 participants