Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'git checkout' in quickOpen (Ctrl+P) #24408

Closed
borekb opened this issue Apr 10, 2017 · 10 comments
Closed

'git checkout' in quickOpen (Ctrl+P) #24408

borekb opened this issue Apr 10, 2017 · 10 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues
Milestone

Comments

@borekb
Copy link

borekb commented Apr 10, 2017

In VSCode 1.10 and earlier, I could do Ctrl+P, git checkout and it would offer me the list of branches. It was a very nice and smooth workflow.

In VSCode 1.11, this seems to be gone. The new "Git: Checkout to..." is the replacement.

Is there any chance that the original way would be reintroduced (maybe the current state is just a limitation of the SCM provider infrastructure), or is it going to stay the way it is?

Note: somewhat related is #21439 (Can no longer create branch).

@jsynowiec
Copy link
Contributor

Probably related to the new git SCM provider that is enabled by default. Please see #24141 and Microsoft/vscode-docs#931. The new git SCM provider is not yet final so this should be reintroduced in future updates.

@joaomoreno
Copy link
Member

Yeah this behaviour is now gone since it's unavailable to extensions, which git has now become.

@joaomoreno joaomoreno added this to the Backlog milestone Apr 10, 2017
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug git GIT issues labels Apr 10, 2017
@borekb
Copy link
Author

borekb commented Apr 10, 2017

@joaomoreno Is there a plan to re-introduce it in a future update?

@joaomoreno
Copy link
Member

Needs API advancements. It should be possible in the future. But not a very near one.

@eamodio
Copy link
Contributor

eamodio commented Apr 10, 2017

@joaomoreno @borekb I could add a "checkout" or "branch switch" command in GitLens in the mean time -- did the old Git extension do anything special to handle error cases? (like if there were uncommitted changes)?

I've been a little hesitant to provide "destructive" operations in GitLens, but since I've already recently added support for stash apply, pop, & delete, this really isn't too different.

@joaomoreno
Copy link
Member

joaomoreno commented Apr 10, 2017

Code comes with a checkout command.

What the user asks for is the ability to type git checkout foo in quick open and check out to a foo branch or create it. You can't do this with an extension today.

@eamodio
Copy link
Contributor

eamodio commented Apr 10, 2017

@joaomoreno oh I see. So no type of extension can provide that, sorry. I completely missed the built-in Git: Checkout to... since I didn't notice that Git is completely dead in the latest insiders build.

EDIT: Never mind on the Git not working -- it was my issue, when I was debugging an extension the new Git extension seems to trigger an unhandled exception (that it didn't used to before today's update) when finding Git, and I didn't notice that I had typed into that file when the exception popped up -- which killed things from then on.

@joaomoreno
Copy link
Member

Can you file an issue for that unhandled exception? 👍

@eamodio
Copy link
Contributor

eamodio commented Apr 11, 2017

Filed: #24482

@joaomoreno
Copy link
Member

To keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed.

Thanks for your understanding. Happy coding!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues
Projects
None yet
Development

No branches or pull requests

4 participants