Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut Stopped Working After Last Update #25118

Closed
claytoncarney opened this issue Apr 21, 2017 · 6 comments
Closed

Shortcut Stopped Working After Last Update #25118

claytoncarney opened this issue Apr 21, 2017 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Milestone

Comments

@claytoncarney
Copy link

  • VSCode Version: Code 1.11.2 (6eaebe3, 2017-04-13T08:03:11.395Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions:
Extension Author Version
vscode-eslint dbaeumer 1.2.8
python donjayamanne 0.6.3
EditorConfig EditorConfig 0.9.3
vscode-sort henriiik 0.2.5
beautify HookyQR 1.0.2
CSSfmt ilich8086 0.0.3
MagicPython magicstack 1.0.9
csharp ms-vscode 1.8.1
python tht13 0.2.3

keybindings.json:
[ { "key": "ctrl+shift+w", "command": "workbench.action.tasks.runTask", "args": "nws" } ]

This shortcut worked prior to the last update. Now it does nothing. I've tried disabling all extensions - still does not work anymore. When I type Ctrl+Shift+P, T, I can see that Tasks: Run Task is assigned to Ctrl+Shift+W

This task references https://www.npmjs.com/package/nws package. I can successfully execute the command from the integrated terminal.

Has something changed in the bindings definitions or is this a bug?

@claytoncarney
Copy link
Author

FYI, tasks.json:
{ "version": "0.1.0", "command": "nws", "isShellCommand": true, "args": ["-o"], "showOutput": "always" }

@alexdima alexdima assigned dbaeumer and unassigned alexdima Apr 24, 2017
@alexdima
Copy link
Member

I don't believe this is a keybindings problem.

@FelikZ
Copy link

FelikZ commented Apr 24, 2017

I have a similar problem for ctrl+shift+2 but not related to exactly last version release. I started using vscode recently and it does not work for me from the start (v1.11.0).

Please see this

Should I create another story or this one would be fine to extend?

@dbaeumer dbaeumer added the tasks Task system issues label Apr 25, 2017
@dbaeumer dbaeumer added this to the April 2017 milestone Apr 25, 2017
@dbaeumer dbaeumer added the bug Issue identified by VS Code Team member as probable bug label Apr 25, 2017
@dbaeumer
Copy link
Member

Works if the task is specified as this:

{
	"version": "0.1.0",
	"command": "echo",
	"isShellCommand": true,
	"showOutput": "always",
	"tasks": [
		{
			"taskName": "echo",
			"args": [
				"Hello World"
			]
		}
	]
}

@dbaeumer
Copy link
Member

@FelikZ this is independent of this issue.

@dbaeumer
Copy link
Member

dbaeumer commented Apr 28, 2017

To verify

Tasks.json

{
	"version": "0.1.0",
	"command": "echo",
	"isShellCommand": true,
	"args": [
		"Hello World"
	],
	"showOutput": "always"
}

Keybinding

	{
		"key": "ctrl+shift+w",
		"command": "workbench.action.tasks.runTask",
		"args": "echo"
	}

Ctrl+Sgift+W should trigger the echo task

@mjbvz mjbvz added the verified Verification succeeded label Apr 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants