Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing confirmation window when discarding changes confirms action #25226

Closed
Vixys opened this issue Apr 24, 2017 · 7 comments
Closed

Closing confirmation window when discarding changes confirms action #25226

Vixys opened this issue Apr 24, 2017 · 7 comments
Assignees
Labels
api bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Milestone

Comments

@Vixys
Copy link

Vixys commented Apr 24, 2017

  • VSCode Version: Code 1.11.2 (6eaebe3, 2017-04-13T08:03:11.395Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions:
Extension Author Version
html-snippets abusaidm 0.1.0
nord-visual-studio-code arcticicestudio 0.1.1
aurelia AureliaEffect 0.2.7
vscode-multi-line-tricks bigous 0.0.3
vue jcbuisson 0.1.5
code-beautifier michelemelluso 1.7.2
vscode-docker PeterJausovec 0.0.13

When discarding changes, hitting escape on the confirmation window will accept and not cancel the action.
Same effect by closing the confirmation window using the close button.

Steps to Reproduce:

  1. Edit a file
  2. On the git panel, hit discard change button on the edited file
  3. Hit escape key after the confirmation window show.
@joaomoreno
Copy link
Member

That's really bad.

@joaomoreno joaomoreno self-assigned this Apr 25, 2017
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority git GIT issues labels Apr 25, 2017
@joaomoreno joaomoreno added this to the April 2017 milestone Apr 25, 2017
@joaomoreno
Copy link
Member

I can't reproduce, can you show a screen recording of this?

@joaomoreno joaomoreno reopened this Apr 26, 2017
@joaomoreno joaomoreno added info-needed Issue requires more information from poster and removed bug Issue identified by VS Code Team member as probable bug git GIT issues important Issue identified as high-priority labels Apr 26, 2017
@joaomoreno joaomoreno removed this from the April 2017 milestone Apr 26, 2017
@Vixys
Copy link
Author

Vixys commented Apr 26, 2017

Here an example with a brand new file. You can see it is removed from my files

@joaomoreno
Copy link
Member

Hmmm still can't repro.

Can you try to reproduce in our insider release?

@joaomoreno
Copy link
Member

I could reproduce! Only seems to happen in the Spanish locale, not English.

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority and removed info-needed Issue requires more information from poster labels Apr 27, 2017
@Vixys
Copy link
Author

Vixys commented Apr 27, 2017

I use vscode with the French locale. Maybe it only works for the English locale.

@joaomoreno
Copy link
Member

Yes, you might be right.

@joaomoreno joaomoreno added this to the April 2017 milestone Apr 27, 2017
@roblourens roblourens added the verified Verification succeeded label Apr 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants