Breakpoints tree does not grow

[alexdima]

I collapsed all the other sections in order to get a good look at the breakpoints, but the list does not adjust to the window size:

[isidorn]

I agree that in this scenario it would be better that the breakpoint view automatically expands to the maximum size.
However on the implementation side it is a AdaptiveCollapsibleViewletView which does not grow past its limit (which is a flow in this case).

just fyi @joaomoreno

[joaomoreno]

Uh-hoh

[isidorn]

@joaomoreno too bad this was not fixed with the split view refactoring

[joaomoreno]

You should fix it at your layer. The breakpoints view should have an infinite max size only if all of the other views have a finite max size; it should be fixed otherwise.

[isidorn]

@joaomoreno I can fix it in my layer but it will be ugly. Currently my DebugViewlet is not aware of all the panes which are contributed.
So I would have to introduce a hack in my debug viewlet to listen to all the changes of all my views and in case that all of them are expanded excepet one I let that one know that it can have an infinite size.

Doesn't it make more sense to handle this internaly in the split view?

Or am I missing something here?

[joaomoreno]

You got the SplitView which gives you the minimalist IView interface. On top of that you have the PanelView which gives you more powerful panels.

If you need a view which dynamically changes the properties of a panel based on all the other panels' states, I'd either code it in the user's domain (DebugViewlet) or create yet another wrapper. Otherwise I have to introduce a maximum size is infinite if all other panels have non-infinite maximum size setting per panel. That's the kind of setting which got us into the old splitview messy code.

Let's code something up together next week?

[bpasero]

Now I am not seeing a scrollbar when breakpoints overflow:

[isidorn]

Unrelated issue which was also happening in stable, please open a new bug. Actually I can open it

[isidorn]

Voila #39796