Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely zooming in and out causes font to slightly blur #254

Closed
Eksrow opened this issue Nov 19, 2015 · 11 comments
Closed

Completely zooming in and out causes font to slightly blur #254

Eksrow opened this issue Nov 19, 2015 · 11 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone

Comments

@Eksrow
Copy link

Eksrow commented Nov 19, 2015

This should probably be very low prio, it probably doesn't happen often.
It's also fixed by restarting visual code.

This is what it looks like default:

default

Now press ctrl++ x 9 times to completely zoom in
Now press ctrl+- x 9 times to completely zoom out

The font now seems blurred

blurred

This is on Windows 8.1
version

Great product btw, I really enjoy using it!

@bpasero bpasero self-assigned this Nov 19, 2015
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Nov 19, 2015
@smuuf
Copy link

smuuf commented Nov 19, 2015

I am probably screwed, since I percieve the VS Code's font blurry even in the default state, aren't I? Will this be fixed? The font is just not sharp enough. :/

@bpasero
Copy link
Member

bpasero commented Nov 19, 2015

@smuuf can you compare with 0.9.x release of VS code? I dont see blurriness on my Windows machine in code. Maybe you are still zoomed in?

@smuuf
Copy link

smuuf commented Nov 19, 2015

Unfortunately I can't compare it with any older version. I installed it today and fiddled a bit with for a bit, until the font's bluriness became too much of a displeasure. (on Win 7, 100 percent DPI)

The question that I really want to ask here is this:

f

This picture (the top one from the original post) - is this how the font should look like? Because it looks too blurry for me, too. Less than in the second one, but still.

@dmitshur
Copy link

@smuuf Are you looking at the image with 100% zoom in a separate tab, so that it's displayed with 1:1 pixel ratio?

https://cloud.githubusercontent.com/assets/4998498/11274683/3350697c-8eda-11e5-8797-806278ef6e93.png

If you're looking at it in this issue, keep in mind it's scaled down via CSS because its full width doesn't fit into the width of the conversation.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed bug Issue identified by VS Code Team member as probable bug labels Nov 24, 2015
@bpasero bpasero modified the milestone: Backlog Nov 26, 2015
@bpasero
Copy link
Member

bpasero commented Apr 21, 2016

We pushed a major update to the UI framework to our insiders release and would appreciate feedback if this issue got resolved. You can give it a try from our insiders release today: http://code.visualstudio.com/Download#insiders

Happy for feedback!

@alexdima
Copy link
Member

alexdima commented May 6, 2016

Fixed (for the case when zooming with ctrl+= or ctrl+- or via window.zoomLevel) with 289370f

@alexdima alexdima closed this as completed May 6, 2016
@alexdima alexdima modified the milestones: May 2016, Backlog May 6, 2016
@dmitshur
Copy link

dmitshur commented May 6, 2016

@alexandrudima Does that mean window zoom level no longer needs to be restricted to 100% and higher (i.e., you can't zoom below 100% with Cmd+-)? I am referring to #434 (comment).

@alexdima
Copy link
Member

alexdima commented May 7, 2016

I think Cmd+- does not go below 100%, but window.zoomLevel: -1 worked for me when doing it from user settings.

@dmitshur
Copy link

dmitshur commented May 7, 2016

I think Cmd+- does not go below 100%

I believe that was implemented because of the blurring issue (see this comment by @bpasero):

We chose to not allow for zooming below 0 because some people end up in this state and wonder why the UI looks blurry.

Now that it's fixed, can't that restriction be lifted?

In other words, isn't forcing user to use window.zoomLevel instead of just Cmd+- to go below 100% no longer neccessary?

@bpasero
Copy link
Member

bpasero commented May 7, 2016

I am easy to change this so that you can also zoom out.

@alexdima alexdima assigned joaomoreno and unassigned alexdima May 27, 2016
@alexdima
Copy link
Member

@joaomoreno You can verify by inspecting that we don't use translate3d on the dom nodes (easiest to spot is the editor scrollbar) when zoomed out or zoomed in.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

6 participants