Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces in block comment. #28169 #28238

Merged
merged 3 commits into from
Jun 14, 2017
Merged

Spaces in block comment. #28169 #28238

merged 3 commits into from
Jun 14, 2017

Conversation

yzhang-gh
Copy link
Contributor

Resolve #28169.

According to that in lineCommentCommand.ts.

@msftclas
Copy link

msftclas commented Jun 8, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. At this time, this PR breaks 13 tests. Could you please look into changing tests where it makes sense and fixing any introduced regressions ?

@yzhang-gh
Copy link
Contributor Author

I've fixed the tests. But I have no idea about this one ...

1) Search-integration Text: GameOfLife:
   Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.

@alexdima alexdima closed this Jun 13, 2017
@alexdima alexdima reopened this Jun 13, 2017
@msftclas
Copy link

@neilsustc,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@alexdima
Copy link
Member

alexdima commented Jun 13, 2017

@neilsustc Thank you, I have closed and reopened the PR to get travis to rerun the build.

This has also triggered our Contribution License Agreement bot to re-evaluate the PR, and, due to the increase in changed lines count, it now requires an agreement. Could you please go through the flow the bot asks for, it is very simple.

@msftclas
Copy link

@neilsustc, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@yzhang-gh
Copy link
Contributor Author

Thanks for your patience 😉

@alexdima alexdima added this to the June 2017 milestone Jun 14, 2017
@alexdima
Copy link
Member

Very nice. Thank you for your contribution @neilsustc ❤️

@alexdima alexdima merged commit 70e2fa4 into microsoft:master Jun 14, 2017
philipmat added a commit to philipmat/Vim that referenced this pull request Jul 13, 2017
This PR: microsoft/vscode#28238 inserts spaces inside block comments, which affects VSCodeVim tests.
Chillee pushed a commit to VSCodeVim/Vim that referenced this pull request Jul 13, 2017
This PR: microsoft/vscode#28238 inserts spaces inside block comments, which affects VSCodeVim tests.
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Space before block comment
3 participants