Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change All Occurrences GUI is hard to use #28528

Closed
Gruntfuggly opened this issue Jun 12, 2017 · 1 comment
Closed

Change All Occurrences GUI is hard to use #28528

Gruntfuggly opened this issue Jun 12, 2017 · 1 comment
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-multicursor Editor multiple cursor issues
Milestone

Comments

@Gruntfuggly
Copy link

I was struggling to use Change All Occurrences because it seemed to locate occurences within words and irrespective of case, which seemed wrong. I guessed that maybe it uses the settings from the Find dialog box, but I also noticed that when selecting Change All Occurrences from the context menu, the case sensitivity and match word 'buttons' appear briefly in the top right hand corner.

Is this to indicate what the search settings are? If you're fast you can click the buttons.

I think it would be nicer to have separate settings for the Change All Occurrences - I would nearly always expect searches to be case sensitive and to match whole words, as I use it to rename variables.

It would also be nice if the buttons stayed around a bit longer?

@joaomoreno joaomoreno assigned jrieken and alexdima and unassigned joaomoreno and jrieken Jun 14, 2017
@alexdima alexdima added the editor-multicursor Editor multiple cursor issues label Sep 28, 2017
@alexdima
Copy link
Member

I believe PR #36682 (for #8869) also fixes this use-case.

  • when right clicking on a word with a collapsed selection, it will search with wholeWords: true, matchCase: true. e.g.
    kapture 2017-10-23 at 15 21 05

  • when right clicking on a non-collapsed selection, it will search for the next match with whatever the find widget options are. The find widget options can be keyboard-controlled, e.g.:

    • match-case: alt+c (win + linux) or cmd+alt+c (mac)
    • whole-words: alt+w (win + linux) or cmd+alt+w (mac)
      e.g.:

kapture 2017-10-23 at 15 21 49

Note: In both cases, the selection highlights will give a preview of what will happen.

@alexdima alexdima added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 23, 2017
@alexdima alexdima added this to the October 2017 milestone Oct 23, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-multicursor Editor multiple cursor issues
Projects
None yet
Development

No branches or pull requests

4 participants