Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added darwinHelpBook and darwinHelpName to build process for MacOS #28654

Merged
merged 1 commit into from
Jun 14, 2017

Conversation

JeremyLoy
Copy link
Contributor

Fixes #18697

Note: The Helpbook files need not exist to fix this bug. Creating a thorough and useful Helpbook is a large feature in its own right. This commit simply enables that book to be made in the future.

@mention-bot
Copy link

@JeremyLoy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joaomoreno and @michelkaporin to be potential reviewers.

@JeremyLoy
Copy link
Contributor Author

JeremyLoy commented Jun 14, 2017

screen shot 2017-06-13 at 11 11 39 pm

screen shot 2017-06-13 at 11 12 20 pm

screen shot 2017-06-13 at 11 13 04 pm

screen shot 2017-06-13 at 11 16 22 pm

Fresh from gulp vscode-darwin...

  1. The info.plist has the new values correctly added
  2. The search term 'light' shows no results in VS Code
  3. The search therm 'light' shows many irrelevant results in Finder
  4. The Help Menu is still useful in VS Code, populated with what is currently specified by hand

@joaomoreno joaomoreno merged commit c8430e6 into microsoft:master Jun 14, 2017
@joaomoreno
Copy link
Member

Excellent, thanks!

@joaomoreno joaomoreno added this to the June 2017 milestone Jun 14, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Mac help topics in Help menu
4 participants