Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isidorn/explorer model #29030

Merged
merged 30 commits into from
Jun 20, 2017
Merged

Isidorn/explorer model #29030

merged 30 commits into from
Jun 20, 2017

Conversation

isidorn
Copy link
Contributor

@isidorn isidorn commented Jun 19, 2017 •
edited

Creating this PR since I believe this is in a decent usable state. Things that still need to be done which I plan to adress asap:

  • special context menu actions for root / empty area
  • fix issue that expansion state is not preserved for non-master roots
  • react when a root gets deleted undearneath
  • honor files.exclude for each of the roots (ask the configurations service for files.exclude)

@isidorn
explorerViewModel.ts -> explorerModel.ts
b5acc69
@isidorn
merge master
6af7ef8
@isidorn
explorerViewModel.test -> explorerModel.test
07b50d9
@isidorn
Merge branch 'master' into isidorn/explorerModel
9069070
@isidorn
fileService.resolveFiles
b275782
@isidorn
explorerModel: Model
5de63ca
@isidorn
explorerViewer: take into account the model when getting children
1e76d7a
@isidorn
explorerView: use isCreated to minimize use of root
c3e8d3a
@isidorn
explorerView: reduce use of root more
8a40164
@isidorn
merge master
dd2cd5f
@isidorn
explorerView: header area, also update on change workspace roots
03c9197
@isidorn
merge with master
0bbdf36
@isidorn
explorerView: remove use of root fully
6a1366d
@isidorn
explorerViewer: steps towards multi root
2e47454
@isidorn
show roots in explorer only when there is more than 1 root
33cdd8d
@isidorn
refresh all parants properly
6d96b62
@isidorn
Merge branch 'master' into isidorn/explorerModel
9af21c6
@isidorn
merge with master
cf73ac2
@isidorn
properly react to workspace change events
fede613
@isidorn
fix revealing of elements
3370fc8
@isidorn
fix drag and drop
a416029
@isidorn
fix issues with having multiple of the same files in different roots
5fccd2b
@isidorn
fix merge conflict
51fcb1c
@isidorn
merge master
7aeeeec
@isidorn
FileStat.root
74f0c4b
@isidorn
do not sort root folders
4e81d18
@isidorn
remove comments
4b15df4
@isidorn isidorn added this to the June 2017 milestone Jun 19, 2017
@isidorn isidorn merged commit 4f33f59 into master Jun 20, 2017
@isidorn isidorn deleted the isidorn/explorerModel branch June 20, 2017 09:58
@isidorn isidorn mentioned this pull request Jun 21, 2017
Closed
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
June 2017
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@isidorn @bpasero @msftclas