Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layer breaker in: vs/workbench/browser/parts/editor/editorStatus.ts #29078

Closed
bpasero opened this issue Jun 20, 2017 · 1 comment
Closed

Layer breaker in: vs/workbench/browser/parts/editor/editorStatus.ts #29078

bpasero opened this issue Jun 20, 2017 · 1 comment
Assignees
@sandy081
Labels
debt Code quality issues
Milestone
April 2018

Comments

@bpasero
Copy link
Member

bpasero commented Jun 20, 2017 •
edited

There is a dependency to IPreferencesService from vs/workbench/parts/preferences/common/preferences.

vs/workbench/parts is like a contrib folder. It should be possible to bundle the workbench without any of those parts.

I suggest to move that service into the vs/workbench/services (= core services) scope thereby.

See https://github.com/Microsoft/vscode/wiki/Code-Organization#workbench-parts
@bpasero bpasero added the debt Code quality issues label Jun 20, 2017
@sandy081 sandy081 added this to the April 2018 milestone Apr 5, 2018
@sandy081
Copy link
Member

sandy081 commented Apr 5, 2018

Moved preferences services to workbench/services as it is being used by multiple parts.

@roblourens FYI

@vscodebot vscodebot bot locked and limited conversation to collaborators May 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
debt Code quality issues
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
2 participants
@bpasero @sandy081