Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persisting zoom in/zoom out settings #291

Closed
dmahugh opened this issue Nov 19, 2015 · 7 comments
Closed

persisting zoom in/zoom out settings #291

dmahugh opened this issue Nov 19, 2015 · 7 comments
Assignees
Labels
verified Verification succeeded
Milestone

Comments

@dmahugh
Copy link

dmahugh commented Nov 19, 2015

The magnification settings (Ctrl+/Ctrl-) reset to the default between sessions, and they also reset to default when opening a new folder. It would be great if these settings were stickier, as they are in many other editors - would eliminate some clumsiness when using Code in presentations, for example.

@seanmcbreen
Copy link

There is a simple extension in the marketplace to help:
https://marketplace.visualstudio.com/items/chrisdias.vscodeZoom

I'll close this for now - reopen if it does not meet your needs.

@bpasero bpasero added this to the Dec 2015 milestone Dec 1, 2015
@bpasero bpasero assigned bpasero and unassigned chrisdias Dec 1, 2015
@bpasero
Copy link
Member

bpasero commented Dec 1, 2015

This will be possible with the newly introduced and persisted window.zoomLevel setting.

@gamtiq
Copy link

gamtiq commented Feb 24, 2016

It would be great if these settings were stickier

I agree.
Using window.zoomLevel setting is not always convenient.
I suppose this should be as "make and forget" action (a user sets the desired zoom level and just works, and don't have to change settings for such feature).

@stkb
Copy link
Contributor

stkb commented Feb 24, 2016

@gamtiq I actually prefer how it works now. When I use the zoom keys it's only for a temporary reason so I'm happy that it resets after I close vscode. Is there a particular reason why using the window.zoomLevel setting isn't convenient?

@gamtiq
Copy link

gamtiq commented Feb 24, 2016

Actually there is no particular reason besides that is necessary to change the setting (and a user should know about window.zoomLevel setting which he can miss as I did).
Moreover the setting's description in User and Workspace Settings is not clear (at least for me).
Should the zoomLevel be integer value? Is fractional value possible? Which are minimal and maximum boundaries?
There is no evidence from documentation.

Maybe it is worth to add a setting that would regulate ability to save and restore zoom level between work sessions.

@stkb
Copy link
Contributor

stkb commented Feb 24, 2016

I agree that there's a discoverability issue with the setting, but that's a really wider a issue that affects other settings too. If you were to add another "zoom persistance" setting, it would have exactly the same discoverability issue!

If you think the window.zoomLevel description could be better, you could always create a PR on the file where it lives, and possibly after that on the vscode-docs repo

Btw, the setting can take any fractional value (something that makes it more powerful than zooming with the keys) and the range seems to be -8 to +9 (which are both ridiculously smaller or bigger than anyone would ever want).

@bpasero
Copy link
Member

bpasero commented Feb 29, 2016

I can make the description clearer.

@bpasero bpasero added the verified Verification succeeded label Apr 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants