Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer: use files.exclude for filterToAddRemovedOnWorkspacePath #29526

Closed
bpasero opened this issue Jun 27, 2017 · 3 comments
Closed

Explorer: use files.exclude for filterToAddRemovedOnWorkspacePath #29526

bpasero opened this issue Jun 27, 2017 · 3 comments
Assignees
Labels
debt Code quality issues file-explorer Explorer widget issues verification-needed Verification of issue is requested verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 27, 2017

There is the last remaining toWorkspaceRelativePath being used in explorer to filter out events on version control folders. Instead of this hardcoded check I suggest to simply read files.exclude and ignore file events from paths that match any of the excludes. Since this check is about updating the explorer it makes sense to ignore file events for paths that are hidden anyways.

@bpasero bpasero added debt Code quality issues file-explorer Explorer widget issues workbench-multiroot Multi-root (multiple folders) issues labels Jun 27, 2017
@isidorn isidorn modified the milestones: July 2017, June 2017 Jun 27, 2017
@isidorn isidorn added the verification-needed Verification of issue is requested label Jun 27, 2017
@isidorn
Copy link
Contributor

isidorn commented Jun 27, 2017

@bpasero please review, I have tried it out and seems to wokr fine. Once you give me the thumbs up I will trigger new builds

@bpasero
Copy link
Member Author

bpasero commented Jun 28, 2017

@isidorn you might want to add some steps for how to verify this, it is not easy because basically you can only verify through debugging.

@isidorn
Copy link
Contributor

isidorn commented Jun 29, 2017

To verify:

  1. Make some changes outside of vscode and make sure the explorer picks up those changes - especially try for one of the slave roots
  2. Open developer tools, add a breakpoint in explorerView doRefresh method. Make some change outside of vscode in a file that is being excluded by files.exclude setting. Verify the breakpoints is not getting hit.

@sandy081 sandy081 added the verified Verification succeeded label Jun 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues file-explorer Explorer widget issues verification-needed Verification of issue is requested verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Development

No branches or pull requests

3 participants