Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Multiroot workspace from command line #29809

Closed
mjbvz opened this issue Jun 28, 2017 · 7 comments
Closed

Open Multiroot workspace from command line #29809

mjbvz opened this issue Jun 28, 2017 · 7 comments
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Milestone

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Jun 28, 2017

If you pass multiple folders to code, we currently open multiple instances of VSCode:

code ~/server ~/client-ios

I believe we should add an option that opens all the passed in folders as roots in a workspace. This could either be the default behavior or controlled with a flag:

code --multiroot ~/server ~/client-ios
@mjbvz mjbvz added feature-request Request for new features or functionality workbench-multiroot Multi-root (multiple folders) issues labels Jun 28, 2017
@Tyriar
Copy link
Member

Tyriar commented Jun 29, 2017

I'd go with changing the default unless there are objections. Any opinions @Microoft/vscode?

@Tyriar Tyriar added this to the Backlog milestone Jun 29, 2017
@bpasero
Copy link
Member

bpasero commented Jul 2, 2017

Makes sense to me. However we should probably also have a new command line argument to add a folder to the last used window.

@Tyriar
Copy link
Member

Tyriar commented Jul 5, 2017

@bpasero that can piggyback on -r? code some-file some-folder will open some-file in an editor and add some-folder to the workspace?

@bpasero
Copy link
Member

bpasero commented Jul 5, 2017

Yeah maybe that is a good idea.

@Tyriar
Copy link
Member

Tyriar commented Jul 5, 2017

Actually maybe that isn't ideal, one of my favorite cli commands is code -r . which would then become a little ambiguous.

@bpasero bpasero self-assigned this Jul 12, 2017
@bpasero bpasero modified the milestones: July 2017, Backlog Jul 12, 2017
@bpasero
Copy link
Member

bpasero commented Jul 13, 2017

Opening a VS Code workspace now works by just typing code myWorkspace.code-workspace from the command line. I extracted #30598 to cover the case of adding additional folders from the command line and #30599 to cover the case of opening multiple folders in one instance.

@bpasero bpasero closed this as completed Jul 13, 2017
@weinand weinand added the verification-needed Verification of issue is requested label Jul 27, 2017
@weinand
Copy link
Contributor

weinand commented Jul 27, 2017

I verified that code myWorkspace.code-workspaceworks.

@weinand weinand added the verified Verification succeeded label Jul 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Development

No branches or pull requests

4 participants