Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightbulb is in the wrong place #29933

Closed
egamma opened this issue Jun 30, 2017 · 2 comments
Closed

Lightbulb is in the wrong place #29933

egamma opened this issue Jun 30, 2017 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-code-actions Editor inplace actions (Ctrl + .) verified Verification succeeded
Milestone

Comments

@egamma
Copy link
Member

egamma commented Jun 30, 2017

From @joaomoreno on June 30, 2017 8:47

From #22517

In the following tslint warning, the lightbulb should appear on line 264. Instead, it appears on the first line of the current selection.

image

Copied from original issue: Microsoft/vscode-tslint#225

@egamma
Copy link
Member Author

egamma commented Jun 30, 2017

This is general behaviour and not vscode-tslint specific

image

Moving to VS Code

@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug editor-code-actions Editor inplace actions (Ctrl + .) labels Jul 10, 2017
@jrieken jrieken added this to the July 2017 milestone Jul 10, 2017
@jrieken
Copy link
Member

jrieken commented Jul 13, 2017

The lightbulb won't show automatically anymore when the selection changes to something non-empty, e.g. dragging the mouse. However, when having a non-empty selection and when manually invoking quick fix we will still take the whole selection range and don't narrow down to any enclosed marker ranges.

@Lixire Lixire added the verified Verification succeeded label Aug 2, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-code-actions Editor inplace actions (Ctrl + .) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants