Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show problems only for currently active file #30038

Closed
vvs opened this issue Jul 3, 2017 · 18 comments
Closed

Show problems only for currently active file #30038

vvs opened this issue Jul 3, 2017 · 18 comments
Assignees
Labels
error-list Problems view feature-request Request for new features or functionality on-testplan
Milestone

Comments

@vvs
Copy link

vvs commented Jul 3, 2017

Coming from Atom, I severely miss the advanced configurablitiy of the "Problems View". See also #7248 and #10400.

Things that I'd like to be able to configure:

  1. Hide Panel when Empty (makes sense when combined with the items 2. and 3.). And: show when non-empty.
  2. Problems View represents Current File
  3. Problems View represents Current Line
  4. Status bar represents Project, Opened Files, Current File, Current Line
  5. Decorate files on the tree to show that they have problems
  6. Mark somehow the current file that it is clean or not clean (without looking into problems view and checking if this file has any errors or not).

Here's a screenshot of the advanced configurability of the Atom editor's problems view (linter-ui-default package). It is VERY well done and provides all needed functionality.

atom-problems-configuration

@sandy081
Copy link
Member

sandy081 commented Oct 6, 2017

Subscribing @jrieken and @bpasero

Some of the features are similar to those you mentioned today.

@jrieken
Copy link
Member

jrieken commented Oct 10, 2017

Decorate files on the tree to show that they have problems

That is tracked in #782

@crucialfelix
Copy link

Also: ability to see the whole problem text, not just a single line. Hovering over it is time consuming and fiddly.

Especially TypeScript errors are very difficult to read even in the pop up:

Argument of type '{ variables: { syncStatus: string; priority: string; admin: boolean; }; optimisticResponse: ({ sy...' is not assignable to parameter of type 'MutationOptions<SetAptSyncStatusPriorityMutationVariables, SetAptSyncStatusPriorityMutation>'.
  Types of property 'optimisticResponse' are incompatible.
    Type '({ syncStatus, priority, admin }: SetAptSyncStatusPriorityMutationVariables) => { [x: string]: st...' is not assignable to type '(variables: SetAptSyncStatusPriorityMutationVariables) => SetAptSyncStatusPriorityMutation'.
      Type '{ [x: string]: string; id: string; }' is not assignable to type 'SetAptSyncStatusPriorityMutation'.
        Property 'setAptSyncStatusPriority' is missing in type '{ [x: string]: string; id: string; }'.

@intijk
Copy link

intijk commented Jan 5, 2018

Yes, for my case I just want this thing could be totally turned off.

@greenais
Copy link

greenais commented Nov 5, 2018

Any progress or ETA on item 2 feature: "Problems View represents Current File"?
There really should be some options to limit helpiness of VS code.
Closing unwanted tabs is the only option now, very annoying

@sandy081
Copy link
Member

sandy081 commented Dec 6, 2018

By Problems View represents Current File you mean, you only want to see Problems from the current file?

@sandy081
Copy link
Member

sandy081 commented Dec 6, 2018

Following are already supported

  1. Decorate files on the tree to show that they have problems
  2. Mark somehow the current file that it is clean or not clean (without looking into problems view and checking if this file has any errors or not).

Not sure what does this mean

  1. Status bar represents Project, Opened Files, Current File, Current Line

Can you please elaborate on this

@greenais
Copy link

greenais commented Dec 6, 2018

@sandy081 yes, I mean exactly that.
When you have 10 tabs/files opened - there is no big sense to see overal amount of problems in all of them them, but definitely there is a real need to see problems in current (active) tab.
Regarding 4. I guess that figures in status bar could represent problems counts in Project / Opened files /Current file like 23 / 11 / 7, but for me personally project level isn't valuable, but current (the most!) and opened (desirable) - are quite.

@sandy081
Copy link
Member

sandy081 commented Dec 7, 2018

Thanks for confirming about Problems View represents Current File.

Regarding 4: We already show that information in the status bar.

image

@greenais
Copy link

greenais commented Dec 9, 2018

@sandy081 I guess you are wrong - just open several files/tabs with problems and make current (active) one by one. You will notice that counts don't change = meaning that status bar represents all currently opened files, not just current/active one.
Or what do you mean by "Current File"?

@sandy081
Copy link
Member

Yes, numbers in status bar represents all problems those are generated, not just for open or active files. If you wish to see the count of only current files, then will you be missing the information about all problems?

@greenais
Copy link

Sure, that's what all above is about - we want to be able to see problems found ONLY in one currently active file.
If you want (for whatever reason) to keep showing problems for all opened/whole project - do it, but let dev see problems for ONLY active file as well (example was provided).
But there is no such option - all only.
That's what all buzz is about.

@sandy081 sandy081 changed the title Advanced configurability for the Problems View is needed Show problems only for currently active file / active line Dec 10, 2018
@sandy081
Copy link
Member

Updated the issue to reflect the missing features.

@sandy081 sandy081 added this to the On Deck milestone Dec 10, 2018
@sandy081 sandy081 changed the title Show problems only for currently active file / active line Show problems only for currently active file Nov 7, 2019
@sandy081
Copy link
Member

sandy081 commented Nov 7, 2019

Active file filter is now available

image

No plans to support active line.

@sandy081 sandy081 modified the milestones: On Deck, November 2019 Nov 7, 2019
@kanlukasz
Copy link

Is it include in October update from yesterday?

@gjsjohnmurray
Copy link
Contributor

No, it is assigned to the November 2019 milestone.

@okaybenji
Copy link

Active file filter is now available

How do I get the filter dropdown shown in this screenshot to activate this feature? I don't see the funnel icon. Instead I have a gear with a minus sign on it:
My filter UI

@sandy081
Copy link
Member

sandy081 commented Dec 4, 2019

This is still in insiders and will be available in stable soon (coming release). You can always download insiders to try.

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
error-list Problems view feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

No branches or pull requests

10 participants