Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Add/Remove Line Comment inserts an unwanted space #30800

Closed
ghost opened this issue Jul 16, 2017 · 3 comments
Closed

Command Add/Remove Line Comment inserts an unwanted space #30800

ghost opened this issue Jul 16, 2017 · 3 comments
Assignees
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling html HTML support issues

Comments

@ghost
Copy link

ghost commented Jul 16, 2017

  • VSCode Version: Code - Insiders 1.15.0-insider (47a49c7, 2017-07-14T07:45:27.194Z)
  • OS Version: Windows_NT x64 10.0.15063
  • Extensions: All extensions have been disabled
Extension Author (truncated) Version
better-comments aar 0.1.2
npm-intellisense chr 1.3.0
path-intellisense chr 1.4.2
vscode-svgviewer css 1.4.2
vscode-eslint dba 1.2.11
vscode-npm-script eg2 0.2.0
auto-close-tag for 0.4.3
auto-complete-tag for 0.0.2
auto-rename-tag for 0.0.14
html-tag-wrapper hwe 0.1.7
search-node-modules jas 1.1.1
HTMLHint mka 0.3.3
atom-keybindings ms- 2.9.1
advanced-new-file pat 0.5.0
vscode-icons rob 7.10.1
stylelint shi 0.27.0
nodejs-extension-pack wad 0.1.9
JavaScriptSnippets xab 1.4.1
html-css-class-completion Zig 1.7.0

(1 theme extensions excluded)


Steps to Reproduce:

  1. Set the Language Mode to CSS
  2. write
body {
  color: #fff;
}
  1. Use Add Line Comment command on an text selection, then Remove Line Comment command
  2. See an extra space before and after the selection

Using Add/Remove Line Comment command (with the Language Mode set to CSS) on an text selection inserts a single space before and after.

Reproduces without extensions: Yes

@spongessuck
Copy link

Also seeing this in 1.14.1 when I just use the add comment shortcut (cmd+/ on macOS) on HTML.

@woncode
Copy link

woncode commented Jul 27, 2017

I'm also meet this issue in 1.14.2

@kieferrm kieferrm closed this as completed Aug 7, 2017
@kieferrm kieferrm added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 7, 2017
@kieferrm kieferrm reopened this Aug 7, 2017
@kieferrm kieferrm added html HTML support issues and removed *duplicate Issue identified as a duplicate of another issue(s) labels Aug 7, 2017
@alexdima
Copy link
Member

alexdima commented Aug 8, 2017

I think PR #30818 resolved this issue:

30800

@alexdima alexdima closed this as completed Aug 8, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling html HTML support issues
Projects
None yet
Development

No branches or pull requests

6 participants