Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve API configuration update() error message #31583

Closed
joaomoreno opened this issue Jul 27, 2017 · 2 comments
Closed

Improve API configuration update() error message #31583

joaomoreno opened this issue Jul 27, 2017 · 2 comments
Assignees
Labels
settings-editor VS Code settings editor issues
Milestone

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Jul 27, 2017

Testing #31448

I attempted to write to a non-resource setting from an extension, under the folder scope. I got this error:

image

Shouldn't the error be more specific? Something in the lines of:

The xxx setting can't be set under the yyy configuration target because zzz.

Something like that?


Related to #31541 due to wording

@sandy081 sandy081 added the settings-editor VS Code settings editor issues label Jul 27, 2017
@sandy081 sandy081 added this to the July 2017 milestone Jul 27, 2017
@joaomoreno
Copy link
Member Author

Similarly, I'm now trying to update a setting on the WorkspaceFolder target, but I scope to a resource which isn't contained by any of the open folders. I get the same generic message:

image

It should describe why I can't do what I'm trying to do.

@sandy081 sandy081 modified the milestones: August 2017, July 2017 Jul 27, 2017
@sandy081
Copy link
Member

Yah this is how we had been reporting for invalid configuration target. Good that we discover such old issues (with wordings) too.

@sandy081 sandy081 modified the milestones: July 2017, August 2017 Jul 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
settings-editor VS Code settings editor issues
Projects
None yet
Development

No branches or pull requests

2 participants