Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Must tab through deleted tab stops in snippets #31619

Closed
lamebear opened this issue Jul 28, 2017 · 3 comments
Closed

Must tab through deleted tab stops in snippets #31619

lamebear opened this issue Jul 28, 2017 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug snippets verified Verification succeeded

Comments

@lamebear
Copy link

  • VSCode Version: 1.14.2
  • OS Version: OSX 10.12.5

Using the following PHP snippet:

"function …": {
	"prefix": "fun",
	"body": [
		"${1:public }function ${2:FunctionName}(${3:${4:${5:Type} }$${6:var}${7: = ${8:null}}})",
		"{",
		"\t${0:# code...}",
		"}"
	],
	"description": "Function"
},

Which generates:

public function FunctionName(Type $var = null)
{
    # code...
}

If I don't want any function arguements and I delete the code inbetween ( and ) that is generated from the snippet, I have to press tab 6 times after entering tabstop 3 to get to tabstop 0.

It would be ideal if the snippet controller and session were able to understand that tab stop 3 was deleted so the nested tab stops would then be ignored.

@0x7FFFFFFFFFFFFFFF
Copy link

Any updates on this issue?

@jrieken jrieken added this to the September 2018 milestone Sep 12, 2018
@jrieken
Copy link
Member

jrieken commented Sep 12, 2018

Yes. This month is issue grooming month and that also means we look at and fix old issues. Such as this one ;-)

@0x7FFFFFFFFFFFFFFF
Copy link

Thanks for the hard work :)

@mjbvz mjbvz added the verified Verification succeeded label Sep 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug snippets verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants