Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolveDocumentLink shouldn't use 'new' links #32788

Closed
jrieken opened this issue Aug 18, 2017 · 0 comments
Closed

resolveDocumentLink shouldn't use 'new' links #32788

jrieken opened this issue Aug 18, 2017 · 0 comments
Assignees
@jrieken
Labels
api debt Code quality issues
Milestone
August 2017

Comments

@jrieken
Copy link
Member

jrieken commented Aug 18, 2017

Like CompletionItems, DocumentLinks that are to be resolved should be kept and the resolve function should receive the original instance. That will allow extensions to keep state in there.

Branched from: #9940 (comment)
@jrieken jrieken self-assigned this Aug 18, 2017
@vscodebot vscodebot bot added the workbench label Aug 18, 2017
@jrieken jrieken added api debt Code quality issues and removed workbench labels Aug 18, 2017
@jrieken jrieken added this to the September 2017 milestone Aug 18, 2017
@jrieken jrieken mentioned this issue Aug 18, 2017
Closed
@jrieken jrieken modified the milestones: August 2017, September 2017 Aug 18, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
api debt Code quality issues
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
1 participant
@jrieken