Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open internal modules in preview tab #33237

Closed
roblourens opened this issue Aug 28, 2017 · 5 comments
Closed

Open internal modules in preview tab #33237

roblourens opened this issue Aug 28, 2017 · 5 comments
Assignees
@isidorn
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2017

Comments

@roblourens
Copy link
Member

  • Debug a node script like this
eval('debugger;//123')
  • When breaking in the eval'd script, leave the tab open in the editor
  • Change the eval'd code in some way, e.g. change the comment
  • Debug it a second time
  • If the same number is assigned, e.g. VM65 on both runs, the editor will open the old version of the script which is already open. It doesn't send a scriptRequest to the debug adapter to get the new script text. This leads to confusing situations when debugging eval code.
@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Aug 28, 2017
@isidorn
Copy link
Contributor

isidorn commented Aug 28, 2017

Dup of an issue that we do not dispose scripts on end of debug session -> there is currently an open issue assigned to Joao but I can not find it.
Since we need a mechansim that debug can tell the content provider that a content is no longer valid.
If you can not find the original issue and you are passionate let me know and I can try harder to dig it up

@isidorn isidorn closed this as completed Aug 28, 2017
@isidorn isidorn added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 28, 2017
@roblourens
Copy link
Member Author

Can they be opened as preview tabs?

@isidorn
Copy link
Contributor

isidorn commented Aug 29, 2017

@roblourens yes we could open all internal modules as preview tabs and I like that idea

@isidorn isidorn changed the title Stale eval scripts shown while debugging Open internal modules in preview tab Aug 29, 2017
@isidorn isidorn reopened this Aug 29, 2017
@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) labels Aug 29, 2017
@isidorn isidorn added this to the August 2017 milestone Aug 29, 2017
@isidorn isidorn added the verification-needed Verification of issue is requested label Aug 30, 2017
@weinand
Copy link
Contributor

weinand commented Aug 31, 2017

@isidorn am I able to set breakpoints in preview tabs?

@isidorn
Copy link
Contributor

isidorn commented Aug 31, 2017

@weinand yes.

@bpasero bpasero added the verified Verification succeeded label Aug 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
4 participants
@roblourens @bpasero @weinand @isidorn