Fix #33155: treat .pac file as javascript file #33245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
Coresi7
changed the title
Coresi7
changed the title
|
Dont know why appveyor build failed for time out because there's no error on my local vscode with the same change. |
|
Thanks! Should be in next insiders build |
|
@mjbvz Thanks~! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#33155: treat .pac file as javascript file
Let vscode auto detect .pac file and use javascript editor to deal with it.
proxy-auto-configuration file is a kind of javascript file which browsers could use it to decide which proxy should use for certain url or ip.
Refer to this wiki for details.
https://en.wikipedia.org/wiki/Proxy_auto-config