Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS errors in HTML aren't prefixed with [html] neither with [js] #33396

Closed
dbaeumer opened this issue Aug 29, 2017 · 0 comments
Closed

JS errors in HTML aren't prefixed with [html] neither with [js] #33396

dbaeumer opened this issue Aug 29, 2017 · 0 comments
Assignees
@aeschli
Labels
feature-request Request for new features or functionality html HTML support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2017

Comments

@dbaeumer
Copy link
Member

dbaeumer commented Aug 29, 2017 •
edited

Testing #33292

Usually we set a source on diagnostics to indicated which LS did generate and error. We should either prefix JS errors in HTML script tags with [html] or [js]

capture
@vscodebot vscodebot bot added the html HTML support issues label Aug 29, 2017
@aeschli aeschli added the feature-request Request for new features or functionality label Aug 31, 2017
@aeschli aeschli added this to the Backlog milestone Aug 31, 2017
@aeschli aeschli modified the milestones: Backlog, November 2017 Nov 21, 2017
@aeschli aeschli added the verification-needed Verification of issue is requested label Dec 4, 2017
@jrieken jrieken added the verified Verification succeeded label Dec 5, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
feature-request Request for new features or functionality html HTML support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
3 participants
@jrieken @dbaeumer @aeschli