Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use checkmark in the menu for Toggle Minimap #33520

Closed
alexdima opened this issue Aug 30, 2017 · 2 comments
Closed

Use checkmark in the menu for Toggle Minimap #33520

alexdima opened this issue Aug 30, 2017 · 2 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Milestone

Comments

@alexdima
Copy link
Member

Extracted from #33456

From @chrisdias


It makes me wonder, why are these all "Toggle"? Why aren't they check marks of on or off, like File | AutoSave.

@vscodebot vscodebot bot added editor editor-minimap Code/Text minimap widget issues labels Aug 30, 2017
@alexdima
Copy link
Member Author

The root cause (at least for the editor specific ones) is that they depend on which editor is focused. Since we have language specific selectors, one can enable minimap in certain file types and disable it in certain file types. We would then need to make the menus update on editor focus change.

fyi @bpasero

@alexdima alexdima added feature-request Request for new features or functionality menu and removed editor editor-minimap Code/Text minimap widget issues labels Aug 30, 2017
@alexdima alexdima removed their assignment Aug 30, 2017
@alexdima alexdima added this to the Backlog milestone Aug 30, 2017
@Tekbr
Copy link

Tekbr commented Oct 19, 2017

-- Sorry for the English, I used Google Translator --

Hello @alexandrudima and @bpasero !!

Would not this be a duplicate of #14986? The difference here asks for a single item. And at #14986 I say to have at all possible.

Thoughts? 🤔

@bpasero bpasero closed this as completed Oct 20, 2017
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 20, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants