Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff editor breaks when running vscode.diff twice in a row #33593

Closed
joaomoreno opened this issue Aug 31, 2017 · 6 comments
Closed

Diff editor breaks when running vscode.diff twice in a row #33593

joaomoreno opened this issue Aug 31, 2017 · 6 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues verified Verification succeeded
Milestone
September 2017

Comments

@joaomoreno
Copy link
Member

This broke it: 062d65d
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues workbench labels Aug 31, 2017
@joaomoreno joaomoreno added this to the August 2017 milestone Aug 31, 2017
@joaomoreno joaomoreno self-assigned this Aug 31, 2017
@joaomoreno
Copy link
Member Author

cc @alexandrudima @bpasero

@joaomoreno
Copy link
Member Author

Fixed by: 2b51e6b

@bpasero
Copy link
Member

bpasero commented Aug 31, 2017

I can still not reproduce this and would be interested in what is happening here in the diff editor.

@joaomoreno
Copy link
Member Author

Oh wow this is going deep.

Bug happens when git extension calls the vscode.diff command twice in a row.

@joaomoreno joaomoreno modified the milestones: Backlog, August 2017 Aug 31, 2017
@joaomoreno joaomoreno changed the title Can't open diff editor Diff editor breaks when running vscode.diff twice in a row Aug 31, 2017
@joaomoreno joaomoreno assigned bpasero and unassigned joaomoreno Aug 31, 2017
@joaomoreno joaomoreno reopened this Aug 31, 2017
@joaomoreno
Copy link
Member Author

Repro steps:

Run this in an extension:

commands.executeCommand<void>('vscode.diff', left, right, title, opts);
commands.executeCommand<void>('vscode.diff', left, right, title, opts);

@bpasero
Copy link
Member

bpasero commented Aug 31, 2017

I see why this is happening but I do not feel good about changing this so late (not a regression either). Will revisit this in September.

@bpasero bpasero added the debt Code quality issues label Aug 31, 2017
@bpasero bpasero closed this as completed in 3d81fe6 Sep 4, 2017
@roblourens roblourens added the verified Verification succeeded label Sep 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
3 participants
@joaomoreno @roblourens @bpasero