Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectionHighlight still slow and blocking for long non-wrapped lines #33885

Closed
myfonj opened this issue Sep 6, 2017 · 3 comments
Closed

selectionHighlight still slow and blocking for long non-wrapped lines #33885

myfonj opened this issue Sep 6, 2017 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@myfonj
Copy link

myfonj commented Sep 6, 2017

  • VSCode Version: Code 1.15.1 (41abd21, 2017-08-16T18:07:25.676Z)
  • OS Version: Windows_NT x64 10.0.15063

Steps to Reproduce:

  1. Save https://upload.wikimedia.org/wikipedia/commons/f/fd/Ghostscript_Tiger.svg and open in VSC.
  2. Ensure settings "editor.selectionHighlight": true and "editor.fontLigatures": true
  3. Select entire document.
  4. Invoke >Join Lines.
  5. If lines are wrapped, invoke >Toggle word wrap .
  6. Select 0 (zero, or any other digit).

Actual behavior:

Editor completely frozen (i.e. does not react for any kind of input) for circa 15 seconds.
After highlights appear editor works normally again.

Expected behavior:

No freeze.
Would not mind missing or delayed highlights.

Notes:

Quite OK with wrapped lines.
Older (closed) issues relevant to this "long lines" topic: #31425 #6885 #13515

Reproduces without extensions: Yes

@alexdima
Copy link
Member

alexdima commented Sep 12, 2017

@myfonj I am thinking we are running into #33525 which is similar, when we don't end up doing our monospace optimizations and end up relying on Chromium to give us the positions of the highlights.

I am thinking this issue reproduces when:

  • not using a monospace font
  • (or) enabling ligatures
  • having a long line with may decorations

Can you please confirm that is the case ?

@alexdima alexdima added the info-needed Issue requires more information from poster label Sep 12, 2017
@myfonj
Copy link
Author

myfonj commented Sep 12, 2017

Ah, ligatures! Yes, confirming: setting "editor.fontLigatures": false prevents described lag from happening.

@alexdima
Copy link
Member

Thank you. Let's continue tracking in #33525

@alexdima alexdima added *duplicate Issue identified as a duplicate of another issue(s) and removed info-needed Issue requires more information from poster labels Sep 22, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants