Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing call to super.dispose() #33963

Closed
wants to merge 1 commit into from
Closed

Add missing call to super.dispose() #33963

wants to merge 1 commit into from

Conversation

nicksnyder
Copy link
Contributor

No description provided.

@mention-bot
Copy link

@nicksnyder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jrieken and @egamma to be potential reviewers.

@jrieken
Copy link
Member

jrieken commented Sep 8, 2017

1c7479e

@sandy081 Why? The ZoneWidget doesn't use anything of widget. So, instead of adding the missing dispose-call I'd opt to not inherit from it

@nicksnyder
Copy link
Contributor Author

It doesn't look like anything in the codebase depends on ZoneWidget extending Widget so you can just close this PR and revert 1c7479e if that is your preference.

@jrieken
Copy link
Member

jrieken commented Sep 8, 2017

Let's wait for @sandy081, tho generally "no source is the best source"

@sandy081
Copy link
Member

Yes, there was no need to extend the Widget class. I had plans to use the ZoneWidget for the Settings editor and needed some changes but was not needed. Looks like above change was slipped in then. Will revert it. Thanks for brining to me.

@jrieken jrieken removed their assignment Sep 12, 2017
@nicksnyder
Copy link
Contributor Author

@sandy081 great, can you git revert 1c7479e970499383d292e1264cfaeda794a24864 and then close this PR without merging

sandy081 added a commit that referenced this pull request Sep 13, 2017
@sandy081
Copy link
Member

There are some merges involved. So removed it in a new change

@sandy081 sandy081 closed this Sep 13, 2017
@nicksnyder nicksnyder deleted the patch-1 branch November 2, 2017 17:33
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants