Add editor.codeActions to enable/disable code actions #33982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieken
requested changes
Sep 8, 2017
There was a problem hiding this comment.
I would not call it like that because you don't disable/enable code actions but the lightbulb. Also, I would give the potential for future settings by using the .enable-pattern. That could/would make it
editor.lightbulb.enable: true/false
editor.lightbulb.onProblems: true/false
editor.lightbulb.delay: number
...
Or some kind of enum, like so
editor.lightbulb = ['on', 'off', 'onForProblems', 'onForSelections']
which needs more thinking because a third value won't fit
jrieken
requested changes
Sep 8, 2017
| this._model.dispose(); | ||
| if (this._model) { | ||
| this._model.dispose(); | ||
| } |
There was a problem hiding this comment.
dispose(this._model) will look much nice
| } | ||
|
|
||
| public triggerFromEditorSelection(): void { | ||
| this._model.trigger('manual'); | ||
| if (this._model) { |
There was a problem hiding this comment.
Yeah, don't do this. Keep the model, enable/disable the lightbulb. The manual invocation should always work
Fixes microsoft#27961 Adds a new `editor.lightbulb.enabled` setting to enable/disable the code actions lighbulb. You can still trigger code actions manually
mjbvz
force-pushed
the
editor-codeActions
branch
from
8962065
to
613a85b
Compare
|
Thanks for the feedback. I've updated the PR to only enable/disable the lightbulb instead of all code actions. I went with the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
editor.codeActionssetting to enable/disable code actions.Fixes #27961