Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up from _readIsISOKeyboard change #34031

Closed
bpasero opened this issue Sep 8, 2017 · 2 comments
Closed

Clean up from _readIsISOKeyboard change #34031

bpasero opened this issue Sep 8, 2017 · 2 comments
Assignees
@alexdima
Labels
debt Code quality issues keybindings VS Code keybinding issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2017

Comments

@bpasero
Copy link
Member

bpasero commented Sep 8, 2017

We should see how the new electron version works with regards to the ISO keyboard remapping and if things are OK we can delete that code on our end.

For now I pushed a change that will always return false for the call to _readIsISOKeyboard
@bpasero bpasero added the keybindings VS Code keybinding issues label Sep 8, 2017
@bpasero bpasero added this to the September 2017 milestone Sep 8, 2017
@bpasero
Copy link
Member Author

bpasero commented Sep 20, 2017

@alexandrudima fyi this has been working quite nicely for me!

@alexdima
Copy link
Member

@bpasero Nice! I can remove the workaround code

@alexdima alexdima added the debt Code quality issues label Sep 21, 2017
@bpasero bpasero removed their assignment Sep 21, 2017
@alexdima alexdima added the verification-needed Verification of issue is requested label Sep 21, 2017
@deysaikat95 deysaikat95 mentioned this issue Sep 25, 2017
Closed
@bpasero bpasero added the verified Verification succeeded label Sep 26, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
debt Code quality issues keybindings VS Code keybinding issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

Successfully merging a pull request may close this issue.

Update from original (#1)
2 participants
@bpasero @alexdima