New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate event firing of onDidClose #34255

Merged

jrieken merged 1 commit into microsoft:master from nicksnyder:patch-4

Sep 13, 2017

Contributor

nicksnyder commented Sep 12, 2017

The dispose method already calls this._onDidClose.fire(this); as its last statement.


          Remove duplicate event firing of onDidClose

246cead

alexdima assigned jrieken

Member

jrieken commented Sep 13, 2017

Thanks.

jrieken added this to the September 2017 milestone

jrieken merged commit 73ae855 into microsoft:master

nicksnyder deleted the patch-4 branch

November 2, 2017 17:32

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.