Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial staging stages additional (deleted) lines selects consecutive lines as well #34360

Closed
laggingreflex opened this issue Sep 14, 2017 · 3 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality git GIT issues
Milestone

Comments

@laggingreflex
Copy link

  • VSCode Version: 1.16
  • OS Version: Win10

Suppose I have 4 total changes: 1 addition and 3 deletions. All these lines are consecutive (so a one "hunk" in Git GUI)

I want to partially stage only the 1 addition.

In Git GUI I would do this:

image

But in VSCode when I try to stage only the 1 addition, it stages the 3 deletions next to it too:

2017-09-14_13-49-19

And when I try to unstage the 2 deletions it again unstages the 1 addition right before it as well:

2017-09-14_13-49-48

Steps to Reproduce:

repro: https://github.com/laggingreflex/vscode-git-test

(Steps to Reproduce in repro readme)

@vscodebot vscodebot bot added the git GIT issues label Sep 14, 2017
@joaomoreno joaomoreno added feature-request Request for new features or functionality and removed new release labels Sep 15, 2017
@joaomoreno joaomoreno removed their assignment Sep 15, 2017
@joaomoreno joaomoreno added this to the Backlog milestone Sep 15, 2017
@laggingreflex
Copy link
Author

Didn't know #34430 was the cause of this (i.e. it didn't supported finer grained staging). I thought it was a bug or something that might've been solved by staging from left side view (#34231). Good to know 👍

@joaomoreno
Copy link
Member

/duplicate #9475

@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 18, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 18, 2018

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Sep 18, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality git GIT issues
Projects
None yet
Development

No branches or pull requests

2 participants