Maintain focus on stopped thread when stepping a multithreaded session #34401
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@isidorn Here's the PR we discussed. |
|
@isidorn , I wanted to check-in with you on this issue. We are releasing our debugger extension soon and it would be great if we can debug multi-threaded without this issue. Do you need any more info from me? |
|
@DatGuyJonathan thank you for your PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There are a couple of issues with multithreaded debugging. When a second thread gets the first stopped event, the UI does not autofocus to that thread. When the user steps the second thread, the UI switches focus to the first thread.
The proposed fix is to allow focus if the currently focused thread is different than the one that wants to be focused on. Also, only auto-focus to the first thread if there's only one thread.
What issues does this PR fix?
#34246