Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More aggressive auto-added SCM provider removal #35041

Closed
jrieken opened this issue Sep 26, 2017 · 2 comments
Closed

More aggressive auto-added SCM provider removal #35041

jrieken opened this issue Sep 26, 2017 · 2 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded
Milestone
September 2017

Comments

@jrieken
Copy link
Member

jrieken commented Sep 26, 2017 •
edited

re #34963

  • have workspace with SCM
  • open a file from another SCM managed folder/workspace
  • you see another provider being added to the SCM viewlet which is good
  • now close the file from step 2
  • 馃悰 the SCM provider is still there, enough I didn't make a change, the repo isn't dirty, the file is gone... I think in such cases (last files of a foreign repo disappears) we should also remove the provider again. Today it makes the "reading a file"-workflow more heavy weight
@vscodebot vscodebot bot added the git GIT issues label Sep 26, 2017
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Sep 27, 2017
@joaomoreno joaomoreno added this to the September 2017 milestone Sep 27, 2017
@joaomoreno
Copy link
Member

Instead, I have added a context menu action to close a repository:

image

@octref octref added the verified Verification succeeded label Sep 28, 2017
@octref
Copy link
Contributor

octref commented Sep 28, 2017

Verified the current solution, but I also think removing SCM provider that doesn't have any associated open workspace / file would make more sense.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
3 participants
@joaomoreno @jrieken @octref