Tasks: possible to run multiple of the same task -> broken terminal dropdown

[isidorn]

Refs: #34953

1. Follow the test plan, run the watch task in a multi folder workspace
2. Delete that entry from tasks.json, run that task again
3. Notice you have two of the same tasks running now (which you are prohibitin in other places)
4. Now terminate one of those tasks, with the task: terminate action (terminate the second one if the first one is shown in the terminal)
5. Notice the terminal dropdown becomes blank and looks broken

There might be some other breakage with having two of the same tasks running, this is the one I noticed.

[dbaeumer]

This is not related to multi workspace setups. The problem is that deleting the task from the tasks.json file make the contributed task the primary task and hence it will not match the already running task. Need to see how to better compare them.

[dbaeumer]

Will investigate the broken terminal drop down for September since it is annoying.

[dbaeumer]

Can't reproduce with a gulp watch task. Need to test npm

[dbaeumer]

Ok. Was able to reproduce this with npm watch task as described in the test plan but I am not able to reproduce the empty drop down. Could this be the old drop down not initializing problem?

Here is what I see:

@isidorn can you reproduce this if you opened the drop down before running any tasks ?

[isidorn]

@dbaeumer now when following the exact steps from above I get a Cannot read property 'toString' of undefined
Here's where it explodes:

[dbaeumer]

Already fixed by: 2e4b6ce

[isidorn]

I agree that the null exception is fixed, just verified, however I still get the broken terminal dropdown following the exact steps from my first comment.
Reopening.
IMHO this is not critical for September.

[dbaeumer]

@isidorn good catch. I thought since you can't run twice the problem doesn't show up again. But two tasks can be named twice.

[dbaeumer]

Got fixed by having a qualified name in the task drop down.

[isidorn]

Verified that the names are now qualified in the task drop down