Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting to exclude symlinks from search paths #36548

Closed
yajo opened this issue Oct 19, 2017 · 2 comments
Closed

Add setting to exclude symlinks from search paths #36548

yajo opened this issue Oct 19, 2017 · 2 comments
Assignees
@roblourens
Labels
feature-request Request for new features or functionality search Search widget and operation issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
October 2017

Comments

@yajo
Copy link

yajo commented Oct 19, 2017 •
edited

  • VSCode Version: Code 1.17.1 (1e9d365, 2017-10-10T14:21:18.489Z)
  • OS Version: Linux x64 4.13.5-200.fc26.x86_64
  • Extensions: Extensions are disabled

Steps to Reproduce:

  1. Open a project with this structure:

    ./src/one_file.js
./srclink -> symlink to ./src

  2. Do a fuzzy search of "onefile".

  3. 2 results will appear, one under each folder.

Before, the workaround explained at #36549 could be used, but since its regression, you only can choose among having several or none results, not just one.

The feature proposal here is to add a setting that allows you to exclude symlinked files from searches automatically.

Reproduces without extensions: Yes
@vscodebot vscodebot bot added the search Search widget and operation issues label Oct 19, 2017
@roblourens roblourens added the feature-request Request for new features or functionality label Oct 20, 2017
@roblourens roblourens added this to the October 2017 milestone Oct 20, 2017
@roblourens roblourens added the verification-needed Verification of issue is requested label Oct 20, 2017
@roblourens roblourens mentioned this issue Oct 20, 2017
Closed
@yajo
Copy link
Author

yajo commented Oct 23, 2017

Thanks! ❤️

@bpasero bpasero added the verified Verification succeeded label Nov 2, 2017
@bpasero
Copy link
Member

bpasero commented Nov 2, 2017

Verified on macOS.

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
feature-request Request for new features or functionality search Search widget and operation issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
October 2017
Development

No branches or pull requests
3 participants
@roblourens @bpasero @yajo