Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links disappear when the terminal is hidden and shown #37103

Closed
Tyriar opened this issue Oct 29, 2017 · 1 comment
Closed

Links disappear when the terminal is hidden and shown #37103

Tyriar opened this issue Oct 29, 2017 · 1 comment
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
July 2018

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 29, 2017 •
edited

Repro:

  1. Create a new terminal
  2. echo 'https://code.visualstudio.com'
  3. Create a new terminal
  4. Switch back to previous terminal, the link doesn't work anymore

It also works with toggling terminal
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Oct 29, 2017
@Tyriar Tyriar added this to the Backlog milestone Oct 29, 2017
@Tyriar Tyriar self-assigned this Oct 29, 2017
@Tyriar Tyriar mentioned this issue Oct 30, 2017
Closed
@Tyriar Tyriar added help wanted Issues identified as good community contribution opportunities upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Jun 21, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Jul 2, 2018

Commenting out this line fixes this

https://github.com/Microsoft/vscode/blob/5f03849cb8ffc77c57b72f28b85bf316f6e60a60/src/vs/workbench/parts/terminal/electron-browser/terminalInstance.ts#L979

@Tyriar Tyriar modified the milestones: Backlog, July 2018 Jul 2, 2018
@Tyriar Tyriar closed this as completed in 832b07b Jul 2, 2018
@roblourens roblourens added the verified Verification succeeded label Aug 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
July 2018
Development

No branches or pull requests
2 participants
@roblourens @Tyriar