Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views: initial opening a view animates all views within #37129

Closed
bpasero opened this issue Oct 30, 2017 · 6 comments
Closed

Views: initial opening a view animates all views within #37129

bpasero opened this issue Oct 30, 2017 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Oct 30, 2017

Steps to Reproduce:

  1. pick a slow os (windows)
  2. reload window with explorer visible
  3. click on extensions view

=> the views within seem to animate from top to bottom
=> I think for the initial display we should not animate the views layouting

flicker_chrome58

@joaomoreno
Copy link
Member

This is a problem with the extension viewlet, and possible the views viewlet because it adds views a bit later.

@bpasero Are you sure it's animated? Isn't it just a view coming in a bit later?

@sandy081
Copy link
Member

Extensions viewlet register Installed and Recommended sections and they are added at the same time to the PanelViewlet.

@joaomoreno May be each add to the viewlet is causing the animation?

@joaomoreno
Copy link
Member

Animation is set only when panels fire onDidChange, not when added/removed. So it might be this: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/browser/parts/views/viewsViewlet.ts#L438

@bpasero
Copy link
Member Author

bpasero commented Oct 30, 2017

Yeah I am for sure seeing an animation, maybe the video did not cover it nicely.

@bpasero
Copy link
Member Author

bpasero commented Oct 31, 2017

@joaomoreno @sandy081 I am seeing a similar animation when typing into the extensions viewlet, waiting for the results to appear and then clearing the search. 2 views are animating in after that.

@sandy081
Copy link
Member

Will talk to @joaomoreno directly to get more knowledge on this :)

@sandy081 sandy081 added this to the October 2017 milestone Nov 1, 2017
@sandy081 sandy081 added workbench bug Issue identified by VS Code Team member as probable bug labels Nov 1, 2017
@sandy081 sandy081 modified the milestones: October 2017, November 2017 Nov 1, 2017
@bpasero bpasero added layout General VS Code workbench layout issues and removed workbench labels Nov 16, 2017
@sandy081 sandy081 modified the milestones: November 2017, Backlog Dec 4, 2017
@bpasero bpasero assigned bpasero and unassigned sandy081 Aug 22, 2018
@bpasero bpasero modified the milestones: Backlog, August 2018 Aug 22, 2018
@sandy081 sandy081 added the verified Verification succeeded label Aug 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants