Rename new git.* decorator color settings

[mjbvz]

From #37159

I found the new git explorer color names, such as "git.untrackedForeground", unclear when first browsing through them. Perhaps include the word explorer or resource in the name to make it explicit where these colors apply? Something like, "git.untrackedResourceForeground" or git.explorer.untrackedForeground

[jrieken]

@aeschli can you help me

[aeschli]

Maybe gitFileDecoration.untrackedResourceForeground.
'explorer' sounds too restrictive to me. We ended up using the file icons also in many places.

@bpasero ?

[aeschli]

Ah, there's already resource. So maybe gitResourceDecoration.untrackedForeground

[jrieken]

Or , gitDecoration.modifiedResourceForeground, gitDecoration.deletedResourceForeground, gitDecoration.untrackedResourceForeground, gitDecoration.ignoredResourceForeground, gitDecoration.conflictResourceForeground

[jrieken]

or gitFileDecoration.untrackedForeground etc

[bpasero]

@jrieken @aeschli are these neutral to the selected SCM provider, and if so should they be prefixed with scm instead of git?

I am fine with gitFileDecoration.<state><foreground> (minus the question around git vs scm)

I find ResourceDecoration a bit technical.

[jrieken]

It's git only. We don't use fileDecoration but just decoration in settings therefore I'd favour gitDecoration.modifiedResourceForeground etc

[bpasero]

@jrieken please also add to https://github.com/Microsoft/vscode-docs/blob/vnext/docs/getstarted/theme-color-reference.md

[jrieken]

It was already there ;-) https://github.com/Microsoft/vscode-docs/blob/vnext/docs/getstarted/theme-color-reference.md#git-colors