Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue reporter includes disabled extensions #37423

Closed
ghost opened this issue Nov 1, 2017 · 5 comments
Closed

Issue reporter includes disabled extensions #37423

ghost opened this issue Nov 1, 2017 · 5 comments
Assignees
@bpasero
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2017

Comments

@ghost
Copy link

ghost commented Nov 1, 2017

  • VSCode Version: Code - Insiders 1.18.0-insider (8deed53, 2017-10-30T05:21:47.015Z)
  • OS Version: Windows_NT x64 10.0.15063
  • Extensions:
Extension Author (truncated) Version
typescript-javascript-grammar ms- 0.0.24

Steps to Reproduce:

  1. Install an extension.
  2. Set it to Disable (always)
  3. Help -> Report Issues

Reproduces without extensions: Yes
@vscodebot vscodebot bot added extensions Issues concerning extensions insiders labels Nov 1, 2017
@bpasero bpasero added feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities good first issue Issues identified as good for first-time contributors labels Nov 2, 2017
@bpasero
Copy link
Member

bpasero commented Nov 2, 2017

Would accept a PR here.

@shobhitchittora
Copy link
Contributor

Hi @bpasero. I'd really like to work on a PR for this. Please guide me through as I'm new to Open Source projects.

@bpasero
Copy link
Member

bpasero commented Nov 3, 2017

The ReportIssueAction is the one invoked here and the task is to hide extensions which are not enabled from the list.

@shobhitchittora
Copy link
Contributor

shobhitchittora commented Nov 4, 2017 •
edited

@bpasero Thanks for pointing it out. I've fixed the issue #37640.

Also my Travis builds are failing. Can you please help?

@shobhitchittora shobhitchittora mentioned this issue Nov 4, 2017
Closed
2 tasks
@bpasero bpasero added this to the November 2017 milestone Nov 4, 2017
@shobhitchittora shobhitchittora mentioned this issue Nov 6, 2017
Merged
2 tasks
@bpasero bpasero added the verification-needed Verification of issue is requested label Nov 6, 2017
@bpasero
Copy link
Member

bpasero commented Nov 6, 2017

Verify: with no extensions disabled, with workspace extensions enabled, with global extensions disabled.

@bpasero bpasero closed this as completed Nov 6, 2017
@sandy081 sandy081 added the verified Verification succeeded label Dec 5, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
extensions Issues concerning extensions feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
3 participants
@bpasero @shobhitchittora @sandy081